Skip to content

Add empty placeholder for domain and data products - #30581

Open
anuj-kumary wants to merge 4 commits into
mainfrom
marketplace-overview-empty-placeholder
Open

Add empty placeholder for domain and data products#30581
anuj-kumary wants to merge 4 commits into
mainfrom
marketplace-overview-empty-placeholder

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Jul 28, 2026

Copy link
Copy Markdown
Member

Describe your changes:

Screenshot 2026-07-28 at 5 19 57 PM Screenshot 2026-07-28 at 5 29 47 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

Adds reusable empty placeholders for empty marketplace domain and data-product widgets.

  • Shows permission-aware creation actions from the new empty states.
  • Adds localized descriptions for all supported languages.
  • Increases the default height of both marketplace widgets to accommodate the richer placeholders.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/components/DataMarketplace/MarketplaceWidgetEmptyState/MarketplaceWidgetEmptyState.component.tsx Introduces a shared icon, title, description, and optional action layout for empty marketplace widgets.
openmetadata-ui/src/main/resources/ui/src/components/DataMarketplace/MarketplaceDataProductsWidget/MarketplaceDataProductsWidget.component.tsx Replaces the basic empty message with a permission-aware data-product placeholder and creation action.
openmetadata-ui/src/main/resources/ui/src/components/DataMarketplace/MarketplaceDomainsWidget/MarketplaceDomainsWidget.component.tsx Replaces the basic empty message with a permission-aware domain placeholder and creation action.
openmetadata-ui/src/main/resources/ui/src/utils/DataMarketplace/DataMarketplaceClassBase.ts Increases the default domain and data-product widget heights to fit the expanded empty states.
openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json Adds descriptions for the domain and data-product empty states, mirrored across the other supported locale files.

Reviews (4): Last reviewed commit: "Merge branch 'main' into marketplace-ove..." | Re-trigger Greptile

@anuj-kumary anuj-kumary self-assigned this Jul 28, 2026
@anuj-kumary
anuj-kumary requested a review from a team as a code owner July 28, 2026 12:00
@anuj-kumary anuj-kumary added safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Jul 28, 2026
@github-actions github-actions Bot added the UI UI specific issues label Jul 28, 2026
Rohit0301
Rohit0301 previously approved these changes Jul 28, 2026
@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Adds empty placeholders for domains and data products in the UI. Consider avoiding template concatenation for the actionLabel to ensure proper translation support.

✅ 1 resolved
Quality: actionLabel built by concatenating translated strings

📄 openmetadata-ui/src/main/resources/ui/src/components/DataMarketplace/MarketplaceDataProductsWidget/MarketplaceDataProductsWidget.component.tsx:260-263 📄 openmetadata-ui/src/main/resources/ui/src/components/DataMarketplace/MarketplaceDomainsWidget/MarketplaceDomainsWidget.component.tsx:243-246
The action label is assembled via template concatenation ${t('label.new')} ${t('label.data-product')}. Concatenating separately-translated fragments breaks word order and spacing in many locales (and RTL languages like ar-sa/he-he), so the rendered button text can be grammatically wrong. Prefer a single interpolated i18n key such as t('label.new-entity', { entity: t('label.data-product') }) (or a dedicated create-entity key) so translators control the whole phrase.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.72% (76874/116963) 49.55% (46131/93087) 50.81% (13907/27369)

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants