Skip to content

feat(adls): Add containerName field to ADLS storage connection - #31540

Merged
akashverma0786 merged 5 commits into
mainfrom
fix-5770
Aug 17, 2026
Merged

feat(adls): Add containerName field to ADLS storage connection#31540
akashverma0786 merged 5 commits into
mainfrom
fix-5770

Conversation

@akashverma0786

@akashverma0786 akashverma0786 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes:

COLLATE PR: https://github.com/open-metadata/openmetadata-collate/pull/5773

Adds a containerName field to the ADLS storage connection schema so a
specific container can be targeted directly, instead of relying only on
containerFilterPattern.

  • Added containerName (string, default "") to
    adlsConnection.json.
  • Regenerated TypeScript types

Type of change:

  • Improvement

High-level design:

N/A — small, additive schema field.

Tests:

Use cases covered

  • ADLS connection config now accepts an explicit containerName.

Unit tests

  • Not added — schema-only additive field, no new logic to cover.

Backend integration tests

  • Not applicable (no backend API changes).

Ingestion integration tests

  • Not applicable (no ingestion source-code changes in this PR).

Playwright (UI) tests

  • Not applicable (no UI changes).

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • For JSON Schema changes: generated code was regenerated via make generate.

Greptile Summary

The PR adds an optional explicit ADLS container name to the canonical storage connection schema and regenerates the affected TypeScript contracts.

  • Adds containerName as an optional string with an empty-string default.
  • Propagates the field through the generated ADLS, storage-service, ingestion-pipeline, automation, and workflow TypeScript interfaces.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope.

No blocking failure remains.

Important Files Changed

Filename Overview
openmetadata-spec/src/main/resources/json/schema/entity/services/connections/storage/adlsConnection.json Adds the optional containerName property to the canonical ADLS connection schema.
openmetadata-ui/src/main/resources/ui/src/generated/entity/services/connections/storage/adlsConnection.ts Regenerates the direct TypeScript ADLS connection interface with the optional field.
openmetadata-ui/src/main/resources/ui/src/generated/api/services/createStorageService.ts Propagates containerName into the generated storage-service creation contract.
openmetadata-ui/src/main/resources/ui/src/generated/entity/services/storageService.ts Propagates containerName into the generated storage-service entity contract.

Reviews (2): Last reviewed commit: "Merge branch 'main' into fix-5770" | Re-trigger Greptile

Context used:

Adds a containerName field to the ADLS connection schema so a specific
container can be targeted directly, and regenerates the derived
TypeScript types.
@akashverma0786 akashverma0786 added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.86% (79900/119502) 51.25% (48765/95141) 52.23% (14596/27942)

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 89bf82aa233a6e49b2477c97257d072401367f26 in Playwright run 32008478034, attempt 1.

✅ 606 passed · ❌ 0 failed · 🟡 2 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 54m 48s

⏱️ Max setup 1m 42s · max shard execution 20m 42s · max shard-job elapsed before upload 23m 56s · reporting 6s

🌐 216.99 requests/attempt · 2.73 app boots/UI scenario · 13.12% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 216.99 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.73 per UI scenario (1722 boots / 631 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
🟡 Shard chromium-01 163 0 2 0 0 0
✅ Shard chromium-02 146 0 0 0 0 0
✅ Shard chromium-03 146 0 0 0 0 0
✅ Shard chromium-04 151 0 0 0 0 0
🟡 2 flaky test(s) (passed on retry)
  • Features/Table.spec.tsshould persist page size (shard chromium-01, 1 retry)
  • Pages/Entity.spec.tsUser as Owner with unsorted list (shard chromium-01, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@pmbrull pmbrull added this to Shipping Aug 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@akashverma0786
akashverma0786 added this pull request to the merge queue Aug 17, 2026
Merged via the queue into main with commit dd018aa Aug 17, 2026
127 of 130 checks passed
@akashverma0786
akashverma0786 deleted the fix-5770 branch August 17, 2026 11:04
@github-project-automation github-project-automation Bot moved this to Done ✅ in Shipping Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 2.0 branch.

github-actions Bot pushed a commit that referenced this pull request Aug 17, 2026
Adds a containerName field to the ADLS connection schema so a specific
container can be targeted directly, and regenerates the derived
TypeScript types.

(cherry picked from commit dd018aa)
@github-actions

Copy link
Copy Markdown
Contributor

Failed to cherry-pick changes to the 1.13 branch.
Please cherry-pick the changes manually.
You can find more details here.

@gitar-bot

gitar-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds the containerName field to the ADLS storage connection schema and regenerates the corresponding TypeScript types. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

Status: Done ✅

Development

Successfully merging this pull request may close these issues.

3 participants