feat(adls): Add containerName field to ADLS storage connection - #31540
Conversation
Adds a containerName field to the ADLS connection schema so a specific container can be targeted directly, and regenerates the derived TypeScript types.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
✅ Playwright Results — workflow succeededValidated commit ✅ 606 passed · ❌ 0 failed · 🟡 2 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 54m 48s ⏱️ Max setup 1m 42s · max shard execution 20m 42s · max shard-job elapsed before upload 23m 56s · reporting 6s 🌐 216.99 requests/attempt · 2.73 app boots/UI scenario · 13.12% common-shard skew Optimization targets still in progress:
🟡 2 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
|
|
|
Changes have been cherry-picked to the 2.0 branch. |
Adds a containerName field to the ADLS connection schema so a specific container can be targeted directly, and regenerates the derived TypeScript types. (cherry picked from commit dd018aa)
|
Failed to cherry-pick changes to the 1.13 branch. |
Code Review ✅ ApprovedAdds the containerName field to the ADLS storage connection schema and regenerates the corresponding TypeScript types. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |



Describe your changes:
COLLATE PR: https://github.com/open-metadata/openmetadata-collate/pull/5773
Adds a
containerNamefield to the ADLS storage connection schema so aspecific container can be targeted directly, instead of relying only on
containerFilterPattern.containerName(string, default"") toadlsConnection.json.Type of change:
High-level design:
N/A — small, additive schema field.
Tests:
Use cases covered
containerName.Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
UI screen recording / screenshots:
Not applicable.
Checklist:
make generate.Greptile Summary
The PR adds an optional explicit ADLS container name to the canonical storage connection schema and regenerates the affected TypeScript contracts.
containerNameas an optional string with an empty-string default.Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope.
No blocking failure remains.
Important Files Changed
containerNameproperty to the canonical ADLS connection schema.containerNameinto the generated storage-service creation contract.containerNameinto the generated storage-service entity contract.Reviews (2): Last reviewed commit: "Merge branch 'main' into fix-5770" | Re-trigger Greptile
Context used: