Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for mask diagonal flip in TTA #5403

Merged
merged 4 commits into from
Jun 25, 2021
Merged

[Feature] Add support for mask diagonal flip in TTA #5403

merged 4 commits into from
Jun 25, 2021

Conversation

yeliudev
Copy link
Contributor

Add support for mask diagonal flip in mmdet/core/post_processing/merge_augs.py for test-time augmentation.

@yeliudev yeliudev changed the title Add support for mask diagonal flip in TTA [Feature] Add support for mask diagonal flip in TTA Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #5403 (9428cae) into master (0e09f00) will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5403      +/-   ##
==========================================
+ Coverage   65.01%   65.06%   +0.05%     
==========================================
  Files         275      276       +1     
  Lines       21262    21293      +31     
  Branches     3537     3542       +5     
==========================================
+ Hits        13824    13855      +31     
+ Misses       6687     6686       -1     
- Partials      751      752       +1     
Flag Coverage Δ
unittests 65.03% <66.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/pipelines/test_time_aug.py 95.65% <ø> (ø)
mmdet/core/post_processing/merge_augs.py 73.97% <66.66%> (+3.97%) ⬆️
mmdet/models/backbones/ssd_vgg.py 65.90% <0.00%> (-21.75%) ⬇️
mmdet/models/dense_heads/ssd_head.py 87.37% <0.00%> (-5.40%) ⬇️
mmdet/models/necks/__init__.py 100.00% <0.00%> (ø)
mmdet/models/necks/ssd_neck.py 100.00% <0.00%> (ø)
mmdet/models/roi_heads/grid_roi_head.py 66.30% <0.00%> (+0.37%) ⬆️
mmdet/models/roi_heads/mask_heads/grid_head.py 96.41% <0.00%> (+1.02%) ⬆️
mmdet/core/bbox/transforms.py 87.50% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e09f00...9428cae. Read the comment docs.

@ZwwWayne ZwwWayne requested a review from xvjiarui June 22, 2021 05:22
@ZwwWayne
Copy link
Collaborator

Hi @yeliudev ,
Thanks for the PR, would you like to also write a unit test for that?

@ZwwWayne ZwwWayne requested a review from hhaAndroid June 22, 2021 08:52
@yeliudev
Copy link
Contributor Author

Hi @yeliudev ,
Thanks for the PR, would you like to also write a unit test for that?

Thanks for your review. I've added the unit tests but I'm not sure whether they are in the right place.

@ZwwWayne ZwwWayne merged commit dd0e8ed into open-mmlab:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants