Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf config #832

Closed
wants to merge 4 commits into from
Closed

Perf config #832

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
493e28c
Added library function which retun True/False if performance collecti…
PraveenPenguin Apr 27, 2024
03e25d2
Added a library function which help to set perf collection attribute …
PraveenPenguin May 3, 2024
b532165
Added support in Machine config as perf collection data can be set vi…
PraveenPenguin Apr 27, 2024
f595b2f
Remove non relevant function docstring
PraveenPenguin Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions common/OpTestHMC.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,20 +927,20 @@ def is_perfcollection_enabled(self):
if rc:
return True
return False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this additional commit? It changes the code(cosmetic changes) added by previous commit? Can we fold this into previous one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as i was looking to add changes align with logging as changes , let me see if some thing messed up while , let me resend

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.. you can just ammend the changes to same previous commit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes closing this PR as have logic separation of commit as some while addressing review comment bank line goes as diffrent commit


def hmc_perfcollect_configure(self, enable=True):
'''
Enable/Disable perfcollection from HMC
enable perfcollection value is 1 and for disable it 0
'''
# Set perf collection profile value using HMC command
cmd = ('chsyscfg -r lpar -m %s -i "name=%s, allow_perf_collection=' %
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is only one double qoute .. is this a typo ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that is correct

2024-05-08 14:52:29,484:op-test.common.OpTestHMC:wait_lpar_state:INFO:Current state: Shutting Down
[console-expect]#lssyscfg -m system -r lpar --filter lpar_names=system-lp13-CR -F state
lssyscfg -m system -r lpar --filter lpar_names=system-lp13-CR -F state
Not Activated
[console-expect]#echo $?
echo $?
0
[console-expect]#lsrefcode -m system -r lpar --filter lpar_names=system-lp13-CR -F refcode
lsrefcode -m system -r lpar --filter lpar_names=system-lp13-CR -F refcode
00000000
[console-expect]#echo $?
echo $?
0
2024-05-08 14:52:44,765:op-test.common.OpTestHMC:wait_lpar_state:INFO:Current state: Not Activated
[console-expect]#lssyscfg -m system -r lpar --filter lpar_names=system-lp13-CR -F allow_perf_collection
lssyscfg -m system -r lpar --filter lpar_names=system-lp13-CR -F allow_perf_collection
1
[console-expect]#echo $?
echo $?
0
2024-05-08 14:52:59,910:op-test.testcases.MachineConfig:LparSetup:INFO:System is already booted with perf collection profile enabled
[console-expect]#lssyscfg -m system -r lpar --filter lpar_names=system-lp13-CR -F state
lssyscfg -m system -r lpar --filter lpar_names=system-lp13-CR -F state
Not Activated
[console-expect]#echo $?
echo $?
0
[console-expect]#lsrefcode -m system -r lpar --filter lpar_names=system-lp13-CR -F refcode
lsrefcode -m system -r lpar --filter lpar_names=system-lp13-CR -F refcode
00000000
[console-expect]#echo $?
echo $?
0
[console-expect]#lssyscfg -m system -r lpar --filter lpar_names=system-lp13-CR -F state
lssyscfg -m system -r lpar --filter lpar_names=system-lp13-CR -F state
Not Activated
[console-expect]#echo $?

(self.mg_system, self.lpar_name))
if enable: # Value '1' to enable perfcollection
if enable:
cmd = '%s1"' % cmd
else: # Value '0' to disable perfcollection
else:
cmd = '%s0"' % cmd
self.run_command(cmd, timeout=300)



class OpTestHMC(HMCUtil):
Expand Down