Skip to content

feat: Ability to set custom fetch function as an option on HTTP transport #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bradjones1 wants to merge 4 commits into from
Closed

feat: Ability to set custom fetch function as an option on HTTP transport #301

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd34771
Ability to set custom fetch function as an option on HTTP transport
bradjones1 Dec 13, 2021
dff3381
Fetch type as any?
bradjones1 Dec 13, 2021
2b07693
Trying to appease the linter
bradjones1 Dec 13, 2021
dd8d207
Falling back to any for fetch type
bradjones1 Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/transports/HTTPTransport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,20 @@ type CredentialsOption = "omit" | "same-origin" | "include"
interface HTTPTransportOptions {
credentials?: CredentialsOption
headers?: Record<string, string>
fetch?: any
Copy link
Author

@bradjones1 bradjones1 Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure what to put here (not a typescript guy...) but the linter didn't like Function

}

class HTTPTransport extends Transport {
public uri: string;
private readonly credentials?: CredentialsOption;
private readonly headers: Headers
private readonly headers: Headers;
private readonly fetch: any;
constructor(uri: string, options?: HTTPTransportOptions) {
super();
this.uri = uri;
this.credentials = options && options.credentials;
this.headers = HTTPTransport.setupHeaders(options && options.headers)
this.headers = HTTPTransport.setupHeaders(options && options.headers);
this.fetch = (options && options.fetch) || fetch;
}
public connect(): Promise<any> {
return Promise.resolve();
Expand All @@ -29,7 +32,7 @@ class HTTPTransport extends Transport {
const notifications = getNotifications(data);
const batch = getBatchRequests(data);
try {
const result = await fetch(this.uri, {
const result = await this.fetch(this.uri, {
method: "POST",
headers: this.headers,
body: JSON.stringify(this.parseData(data)),
Expand Down