fix: add normalization dot for method name#728
Open
ja7ad wants to merge 7 commits intoopen-rpc:masterfrom
Open
fix: add normalization dot for method name#728ja7ad wants to merge 7 commits intoopen-rpc:masterfrom
ja7ad wants to merge 7 commits intoopen-rpc:masterfrom
Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 99.19% 99.20% +0.01%
==========================================
Files 6 7 +1
Lines 247 253 +6
Branches 25 27 +2
==========================================
+ Hits 245 251 +6
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a027838 to
7307ecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks if the method name contains a
"."and normalizes it to camelCase.Fixes #619