Skip to content

FIX: Edges appending to only one instance of Svelvet container #513#515

Closed
turizspace wants to merge 1 commit intoopen-source-labs:mainfrom
turizspace:main
Closed

FIX: Edges appending to only one instance of Svelvet container #513#515
turizspace wants to merge 1 commit intoopen-source-labs:mainfrom
turizspace:main

Conversation

@turizspace
Copy link
Copy Markdown

Updated moveEdge function in Edge.svelte to correctly append the edge element to its respective Svelvet container based on containerId.

🔗 Linked issue

Resolves #513

🔗 Linked issue

Resolves #513

Description

  • Enhanced moveEdge function in Edge.svelte to ensure proper appending of edge elements to their respective Svelvet containers.
  • Previous implementation relied on static container selection, causing edges to append inconsistently across multiple Svelvet instances.
  • Refactored moveEdge to dynamically fetch the container using containerId, ensuring edges are appended to the correct instance based on context.
  • This change resolves visual inconsistencies and improves the reliability of edge rendering in complex Svelvet applications.

Checklist

  • I've followed the Contributing guidelines

  • I've titled my PR according to the Conventional Commits spec

  • I've linked an open issue

  • I've added tests that fail without this PR but pass with it

  • I've linted and tested my code

  • I've updated documentation (if appropriate)

    Updated moveEdge function in Edge.svelte to correctly append the edge element to its respective Svelvet container based on containerId.

🔗 Linked issue

Resolves #513
@turizspace turizspace closed this by deleting the head repository May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edges appending to only one instance of Svelvet container

1 participant