Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opamp-spec to v0.12.0 #362

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Mar 17, 2025

Update the opamp-spec to https://github.com/open-telemetry/opamp-spec/releases/tag/v0.12.0 And regenerate the ProtoBufs.
Required to unblock #341

@michel-laterman michel-laterman requested a review from a team as a code owner March 17, 2025 21:00
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (182c2bb) to head (94a2508).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   80.10%   79.57%   -0.54%     
==========================================
  Files          25       25              
  Lines        2423     2423              
==========================================
- Hits         1941     1928      -13     
- Misses        374      384      +10     
- Partials      108      111       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michel-laterman
Copy link
Contributor Author

@tigrannajaryan, @andykellr, can I please get a review for this?

@tigrannajaryan
Copy link
Member

Let's make a opamp-spec v0.12.0 release and consume that instead of consuming a specific unreleased submodule commit.

I will prepare a changelog: open-telemetry/opamp-spec#215

@tigrannajaryan
Copy link
Member

opamp-spec v0.12.0 released, please use it in this PR: https://github.com/open-telemetry/opamp-spec/releases/tag/v0.12.0

@michel-laterman michel-laterman changed the title Update opamp-spec to main for download rate change Update opamp-spec to v0.12.0 Mar 19, 2025
@tigrannajaryan tigrannajaryan merged commit d6ca1cf into open-telemetry:main Mar 19, 2025
10 of 11 checks passed
@michel-laterman michel-laterman deleted the update-spec branch March 20, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants