[chore] .github: match components in reverse order in add-codeowners-to-pr script #38574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a component matches a file, the file is removed from the set so it won't be processed again. This means that if a file cannot match multiple components. In order to assign the correct PR owners for nested components, we need to make sure we process those components before their ancestors. Each group of components is already in lexicographical order, so we can just reverse the order.
mx-psi
approved these changes
Mar 12, 2025
edmocosta
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a component matches a file, the file is removed from the set so it won't be processed again:
opentelemetry-collector-contrib/.github/workflows/scripts/add-codeowners-to-pr.sh
Lines 68 to 69 in 62488e4
This means that if a file cannot match multiple components. For example, I am not getting assigned to PRs that modify
extension/encoding/awscloudwatchmetricstreamsencodingextension, since all of its files will first match theextension/encodingcomponent path.In order to assign the correct PR owners for nested components, we need to make sure we process those components before their ancestors. Each group of components is already in lexicographical order, so we can just reverse the order.
Link to tracking issue
N/A
Testing
Verified by running
REPO=open-telemetry/opentelemetry-collector-contrib PR=38516 bash .github/workflows/scripts/add-codeowners-to-pr.shwith theghcalls commented out.Documentation
N/A