Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector/datadog] remove TracesConfig #38661

Merged
merged 1 commit into from
Mar 17, 2025
Merged

[connector/datadog] remove TracesConfig #38661

merged 1 commit into from
Mar 17, 2025

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 17, 2025

No description provided.

@atoulme atoulme requested review from mx-psi and a team as code owners March 17, 2025 00:29
@atoulme atoulme force-pushed the remove_deprecated_struct branch from 73b3609 to 0c0324f Compare March 17, 2025 00:29
@atoulme atoulme force-pushed the remove_deprecated_struct branch from 0c0324f to 432d267 Compare March 17, 2025 00:43
@atoulme atoulme force-pushed the remove_deprecated_struct branch from 432d267 to ec7d3a1 Compare March 17, 2025 00:51
MovieStoreGuy
MovieStoreGuy reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the connector config a like for like type?

@atoulme
Copy link
Contributor Author

atoulme commented Mar 17, 2025

Is the connector config a like for like type?

Looks like it. A codeowner can review and confirm.

mx-psi
mx-psi approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

songy23
songy23 approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thx!

@songy23 songy23 merged commit eb9d654 into open-telemetry:main Mar 17, 2025
171 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MovieStoreGuy MovieStoreGuy MovieStoreGuy left review comments

@mx-psi mx-psi mx-psi approved these changes

@songy23 songy23 songy23 approved these changes

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@IbraheemA IbraheemA Awaiting requested review from IbraheemA

@jade-guiton-dd jade-guiton-dd Awaiting requested review from jade-guiton-dd

Assignees

@songy23 songy23

Labels
connector/datadog
Projects
None yet
Milestone
v0.122.0
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @mx-psi @songy23 @MovieStoreGuy