[chore] Cleanup for extensionauth.Server update #38796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/otelarrow
extension/oidcauth
extension/basicauth
labels
github-actions
bot
requested review from
frzifus,
jmacd,
jpkrohling and
moh-osman3
mx-psi
force-pushed
the
mx-psi/extensionauth-server
branch
from
79ca6fc to
9b2834b
Compare
TylerHelmuth
approved these changes
Mar 19, 2025
lightme16
pushed a commit
to lightme16/opentelemetry-collector-contrib
that referenced
this pull request
Mar 19, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description I intend to make `extensionauth.Server` independent of `extension.Extension` with open-telemetry/opentelemetry-collector/pull/12672. This means some changes in tests and such to make sure that we cast to the right interface when calling each method. This should have no visible impact to end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I intend to make
extensionauth.Serverindependent ofextension.Extensionwith open-telemetry/opentelemetry-collector/pull/12672. This means some changes in tests and such to make sure that we cast to the right interface when calling each method. This should have no visible impact to end users.