[mdatagen] fix missing resource attributes import in metrics template #12456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12456 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 465 465
Lines 25173 25173
=======================================
Hits 23184 23184
Misses 1592 1592
Partials 397 397 ☔ View full report in Codecov by Sentry. |
jmacd
approved these changes
Feb 21, 2025
bogdandrutu
approved these changes
Feb 21, 2025
Merged
via the queue into
open-telemetry:main
with commit Feb 21, 2025
bf1a374
54 of 55 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-adds the missing import for the
ResourceAttributesfor metrics generation. This impacts receivers that emit resource attributes. Filter is still within the template code for resource attributes, but not imported.Link to tracking issue
Fixes #12455