document breaking change in metric names for prometheus exporter #12500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#12458 Signed-off-by: Alex Boten <[email protected]>
bogdandrutu
reviewed
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12500 +/- ##
==========================================
- Coverage 92.16% 92.00% -0.17%
==========================================
Files 465 469 +4
Lines 25201 25355 +154
==========================================
+ Hits 23226 23327 +101
- Misses 1576 1619 +43
- Partials 399 409 +10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <[email protected]>
songy23
approved these changes
Feb 26, 2025
jmacd
approved these changes
Feb 26, 2025
songy23
reviewed
Feb 26, 2025
|
|
||
| The change to update the internal telemetry to use [otel-go config](https://pkg.go.dev/go.opentelemetry.io/contrib/config) can cause unexpected behaviour | ||
| for end users. This change is caused by the default values in `config` being different from what the Collector has used in previous versions. The | ||
| following changes can occur when users configure their `service::telemetry::metrics::readers`: |
There was a problem hiding this comment.
QQ: does it mean as long as you don't explicitly configure readers you won't run into this? e.g. if I just have
service:
telemetry:
metrics:
level: detailed
the behavior of this should be the same in all versions, right?
There was a problem hiding this comment.
Yes, I think it worth mentioning that the breaking change only affects user how customized the prometheus reader in any way. The default behavior is the same
bogdandrutu
approved these changes
Feb 26, 2025
codeboten
commented
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12458