Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WithType functions #12544

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 4, 2025

Description

Removes deprecated NewNopSettingsWithType functions

Link to tracking issue

Updates #12221, follows #12452

@mx-psi mx-psi requested a review from sincejune March 4, 2025 10:15
@mx-psi mx-psi marked this pull request as ready for review March 4, 2025 10:21
@mx-psi mx-psi requested a review from a team as a code owner March 4, 2025 10:21
@mx-psi mx-psi requested a review from TylerHelmuth March 4, 2025 10:21
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (72878b7) to head (84492bf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12544      +/-   ##
==========================================
+ Coverage   92.02%   92.13%   +0.10%     
==========================================
  Files         469      469              
  Lines       25318    25288      -30     
==========================================
  Hits        23299    23299              
+ Misses       1612     1582      -30     
  Partials      407      407              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi enabled auto-merge March 4, 2025 11:28
@mx-psi mx-psi added this pull request to the merge queue Mar 4, 2025
Merged via the queue into open-telemetry:main with commit bbc30fd Mar 4, 2025
59 of 73 checks passed
@mx-psi mx-psi deleted the mx-psi/remove-withtype branch March 4, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants