Skip to content

[chore] Bytes based batching for profiles #12564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

iblancasa
Copy link
Contributor

Description

This PR implements serialized bytes based batching for metrics.

Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

Related PRs:

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 79.54545% with 27 lines in your changes missing coverage. Please review.

Project coverage is 91.38%. Comparing base (7d854d5) to head (4e3c2ad).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/exporterhelper/internal/sizer/profiles_sizer.go 0.00% 14 Missing ⚠️
...r/exporterhelper/xexporterhelper/profiles_batch.go 92.85% 6 Missing and 1 partial ⚠️
pdata/pprofile/pb.go 40.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (79.54%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12564      +/-   ##
==========================================
- Coverage   91.46%   91.38%   -0.08%     
==========================================
  Files         483      484       +1     
  Lines       26624    26695      +71     
==========================================
+ Hits        24351    24396      +45     
- Misses       1791     1817      +26     
  Partials      482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi requested a review from sfc-gh-sili March 5, 2025 12:53
@iblancasa iblancasa force-pushed the profiles-sizer branch 2 times, most recently from 8c64251 to ddedc5b Compare March 17, 2025 11:35
@iblancasa iblancasa requested a review from sfc-gh-sili March 17, 2025 11:59
@iblancasa
Copy link
Contributor Author

@dmitryax @bogdandrutu

@iblancasa
Copy link
Contributor Author

Fixed conflicts. Can you review? @dmitryax @bogdandrutu

@iblancasa iblancasa force-pushed the profiles-sizer branch 3 times, most recently from 2d45881 to 6979d6f Compare March 25, 2025 14:42
@iblancasa iblancasa changed the title Bytes based batching for profiles [chore] Bytes based batching for profiles Mar 25, 2025
@iblancasa iblancasa force-pushed the profiles-sizer branch 3 times, most recently from 7ed4333 to 7057322 Compare April 1, 2025 21:54
@dmitryax dmitryax added this pull request to the merge queue Apr 2, 2025
@dmitryax dmitryax removed this pull request from the merge queue due to a manual request Apr 2, 2025
@dmitryax
Copy link
Member

dmitryax commented Apr 2, 2025

I believe this actually needs the changelog item now given that we enabled the bytes batching already

@iblancasa
Copy link
Contributor Author

I believe this actually needs the changelog item now given that we enabled the bytes batching already

Added. I think we are ready to go.

@dmitryax dmitryax added this pull request to the merge queue Apr 2, 2025
Merged via the queue into open-telemetry:main with commit 63a22b2 Apr 2, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants