[extensionauthtest] Remove extensionauthtest.MockClient #12567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/seal-them-all
branch
3 times, most recently
from
e085777 to
744695d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12567 +/- ##
==========================================
- Coverage 92.18% 92.18% -0.01%
==========================================
Files 469 469
Lines 25395 25390 -5
==========================================
- Hits 23410 23405 -5
Misses 1574 1574
Partials 411 411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mx-psi
force-pushed
the
mx-psi/seal-them-all
branch
from
744695d to
5dbeb2a
Compare
jmacd
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
extensionauthtest.MockClient. Users can use eitherextensionauth.NewClientor useextensionauthtest.NewErrorClientas a convenience method to replicate theMustErrorfield behavior.Doing a Github search, I am unable to find usages of this outside of contrib, which I dealt with on PR open-telemetry/opentelemetry-collector-contrib/pull/38401, thus I believe this should be fine to remove in one go.