-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Equal
comparison in pcommon types
#12594
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (93.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12594 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 473 473
Lines 25590 25650 +60
=======================================
+ Hits 23567 23623 +56
- Misses 1612 1615 +3
- Partials 411 412 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
37e38f9
Description
This introduces
.Equal()
methods to most pcommon types, so equality comparison can be performed with no allocations.The types
Equal
is added to are:Value
ByteSlice
Float64Slice
Int32Slice
Int64Slice
StringSlice
Uint64Slice
Map
Slice
The original intent was to add it to
Value
. However, to be able to handle every type in there, I had to also add it to the other types, some of which are coming too because they are auto-generated.Link to tracking issue
Fixes #12561
This is the same thing as #12568, but with comparison of pcommon types rather than raw ones.
Testing
Here are the results from the new benchmarks.