-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service] Allow running the Collector without any pipelines #12613
Conversation
I decided to go with only a feature gate instead of a command line option because adding the command line option meaningfully complicates the code for what is in my opinion not sufficient gain. I think we could either:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12613 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 478 478
Lines 26456 26456
=======================================
Hits 24250 24250
Misses 1747 1747
Partials 459 459 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
why not a flag in the config?
This would be useful for Jaeger where |
I think this is something we can discuss before we mark this feature gate as beta. I filed #12646 to continue the discussion |
8ebe098
Description
Adds a feature gate that allows starting the Collector without running any pipelines. This will mainly be used for OpAMP, where the Collector may need to be started with only extensions