Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Allow running the Collector without any pipelines #12613

Merged
merged 7 commits into from
Mar 17, 2025

Conversation

evan-bradley
Copy link
Contributor

Description

Adds a feature gate that allows starting the Collector without running any pipelines. This will mainly be used for OpAMP, where the Collector may need to be started with only extensions

@evan-bradley evan-bradley requested a review from a team as a code owner March 11, 2025 18:37
@evan-bradley evan-bradley requested a review from atoulme March 11, 2025 18:37
@evan-bradley
Copy link
Contributor Author

I decided to go with only a feature gate instead of a command line option because adding the command line option meaningfully complicates the code for what is in my opinion not sufficient gain. I think we could either:

  1. Abuse the feature gate system a bit and leave this as an alpha-stage feature gate for the indefinite future.
  2. Move to print warnings or similar when no pipelines are enabled. I don't think this would likely be a big deal.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (0e9e259) to head (1e629df).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12613   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files         478      478           
  Lines       26456    26456           
=======================================
  Hits        24250    24250           
  Misses       1747     1747           
  Partials      459      459           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi requested a review from bogdandrutu March 13, 2025 15:34
@evan-bradley evan-bradley added the ready-to-merge Code review completed; ready to merge by maintainers label Mar 14, 2025
@yurishkuro
Copy link
Member

why not a flag in the config?

service:
  extensions: [...]
  pipelines:
    disabled: true

This would be useful for Jaeger where jaeger-query also needs only extensions, not the pipeline. Currently we're using nop components to disable the pipelines.

@mx-psi
Copy link
Member

mx-psi commented Mar 17, 2025

why not a flag in the config?

I think this is something we can discuss before we mark this feature gate as beta. I filed #12646 to continue the discussion

@mx-psi mx-psi added this pull request to the merge queue Mar 17, 2025
Merged via the queue into open-telemetry:main with commit 8ebe098 Mar 17, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants