Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process metrics disable #12615

Merged
merged 6 commits into from
Mar 13, 2025

Conversation

Dylan-M
Copy link
Contributor

@Dylan-M Dylan-M commented Mar 11, 2025

Description

Process registration protection for telemetry level being set to "None"

Link to tracking issue

Fixes #12098

Testing

Manual testing on an AIX 7.3 system rented from SiteOx:

-bash-5.2# ./otelcorecol_aix_ppc64 --config ./example.yaml 
2025-03-11T16:52:04.318-0500    info    [email protected]/service.go:193 Setting up own telemetry...
2025-03-11T16:52:04.318-0500    info    [email protected]/service.go:238 Skipped telemetry setup.
2025-03-11T16:52:04.318-0500    info    [email protected]/service.go:260 Starting otelcorecol... {"Version": "0.121.0-dev", "NumCPU": 8}
2025-03-11T16:52:04.319-0500    info    extensions/extensions.go:40     Starting extensions...
2025-03-11T16:52:04.319-0500    info    [email protected]/service.go:283 Everything is ready. Begin running and processing data.
2025-03-11T16:52:13.786-0500  info    [email protected]/collector.go:342       Received signal from OS {"signal": "interrupt"}
2025-03-11T16:52:13.786-0500    info    [email protected]/service.go:325 Starting shutdown...
2025-03-11T16:52:13.786-0500    info    extensions/extensions.go:68     Stopping extensions...
2025-03-11T16:52:13.786-0500    info    [email protected]/service.go:339 Shutdown complete.

@Dylan-M Dylan-M requested a review from a team as a code owner March 11, 2025 22:03
@Dylan-M Dylan-M requested a review from bogdandrutu March 11, 2025 22:03
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.09%. Comparing base (d3c5895) to head (c6c7096).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
service/service.go 50.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12615      +/-   ##
==========================================
- Coverage   92.16%   92.09%   -0.07%     
==========================================
  Files         471      473       +2     
  Lines       25561    25592      +31     
==========================================
+ Hits        23558    23569      +11     
- Misses       1591     1612      +21     
+ Partials      412      411       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mx-psi mx-psi added this pull request to the merge queue Mar 13, 2025
Merged via the queue into open-telemetry:main with commit 0174095 Mar 13, 2025
54 of 55 checks passed
@Dylan-M Dylan-M deleted the fix_process_metrics_disable branch March 13, 2025 13:17
@mdirkse
Copy link

mdirkse commented Mar 13, 2025

Thanks! You just seriously simplified my upgrade process ;)

@Dylan-M
Copy link
Contributor Author

Dylan-M commented Mar 13, 2025

Thanks! You just seriously simplified my upgrade process ;)

I'm still working on updating gopsutil so that we don't need to disable the internal metrics on AIX and other systems. It has ended up being a larger project than I expected because my AI code assistant is useless for AIX. It generates code that looks good, but is a pure hallucination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in PR #11093 Broke Disabling Internal Telemety For OSes On Which It Isn't Implemented (ie. AIX)
3 participants