-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdatagen] Support logs #12659
Open
sincejune
wants to merge
7
commits into
open-telemetry:main
Choose a base branch
from
sincejune:mdatagen-logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[mdatagen] Support logs #12659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12659 +/- ##
==========================================
+ Coverage 91.46% 91.50% +0.04%
==========================================
Files 483 486 +3
Lines 26624 26737 +113
==========================================
+ Hits 24351 24466 +115
+ Misses 1791 1788 -3
- Partials 482 483 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3abeb28
to
6914694
Compare
dmitryax
approved these changes
Mar 28, 2025
This PR introduces changes to go mod files. I'll update otel core version in the contrib repo once merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the foundational changes necessary for supporting
logs
data in themdatagen
tool.mdatagen files for logs
This update includes the generation of
generated_logs.go
andgenerated_logs_test.go
. These files are specifically for receiver and scraper components that supportlogs
data, enabling initial log handling capabilities.Introducing LogsBuilder
This PR introduced a
LogsBuilder
similar to the existingMetricsBuilder
. It provides a structured way to manage log data with the following functions:Emit(...ResourceLogsOption)
Similar to
Emit
function in MetricsBuilderEmitForResource(...ResourceLogsOption)
Similar to
EmitForResource
function in MetricsBuilderAppendLogRecord(plog.LogRecord)
This function appends a log record to an internal buffer. The buffered log records are used to construct a
ScopeLog
when theEmit()
orEmitForResource()
functions are called. Scope name and version are automatically generated.Next steps
metadata.yml
to send structured logsExample usage:
Example output:
Link to tracking issue
Part of #12571
Testing
Added
Documentation
Added