Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply v1.28.1/v0.122.1 changes to main #12667

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Apply v1.28.1/v0.122.1 changes to main #12667

merged 2 commits into from
Mar 18, 2025

Conversation

codeboten
Copy link
Contributor

Note to maintainers: DO NOT SQUASH MERGE THIS CHANGE

evan-bradley and others added 2 commits March 18, 2025 13:01
#### Description

#11882
introduced issues with handling slices which have default values. It's
likely that the removal of `zeroSliceHookFunc` is causing problems with
overriding default lists.
The following commands were run to prepare this release:

* make chlog-update VERSION=v1.28.1/v0.122.1
* make prepare-release PREVIOUS_VERSION=1[.]28[.]0
RELEASE_CANDIDATE=1.28.1 MODSET=stable
* make prepare-release PREVIOUS_VERSION=0[.]122[.]0
RELEASE_CANDIDATE=0.122.1 MODSET=beta

---------

Co-authored-by: opentelemetrybot <[email protected]>
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 18, 2025
Copy link

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing change log ci is expected and the AIX cross build is an existing issue from what I recall. Giving approval on mobile so this isn't blocked.

Edit: oops, this isn't in contrib, I can't unblock.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (8bc15fd) to head (a17839e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12667   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         479      479           
  Lines       26423    26423           
=======================================
  Hits        24214    24214           
  Misses       1749     1749           
  Partials      460      460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten
Copy link
Contributor Author

skipping contrib as those tests are also failing main currently

@codeboten
Copy link
Contributor Author

AIX tests also failing

@codeboten codeboten merged commit e529b31 into main Mar 18, 2025
60 of 69 checks passed
@codeboten codeboten deleted the release/v0.122.x branch March 18, 2025 22:15
@codeboten codeboten restored the release/v0.122.x branch March 18, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants