-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply v1.28.1/v0.122.1 changes to main #12667
Conversation
#### Description #11882 introduced issues with handling slices which have default values. It's likely that the removal of `zeroSliceHookFunc` is causing problems with overriding default lists.
The following commands were run to prepare this release: * make chlog-update VERSION=v1.28.1/v0.122.1 * make prepare-release PREVIOUS_VERSION=1[.]28[.]0 RELEASE_CANDIDATE=1.28.1 MODSET=stable * make prepare-release PREVIOUS_VERSION=0[.]122[.]0 RELEASE_CANDIDATE=0.122.1 MODSET=beta --------- Co-authored-by: opentelemetrybot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing change log ci is expected and the AIX cross build is an existing issue from what I recall. Giving approval on mobile so this isn't blocked.
Edit: oops, this isn't in contrib, I can't unblock.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12667 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 479 479
Lines 26423 26423
=======================================
Hits 24214 24214
Misses 1749 1749
Partials 460 460 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skipping contrib as those tests are also failing main currently |
AIX tests also failing |
Note to maintainers: DO NOT SQUASH MERGE THIS CHANGE