Revert "fix(deps): update module github.com/prometheus/common to v0.63.0 (#12656)" #12673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3.0 (open-telemetry#12656)" This reverts commit c11fa87.
1 task
jade-guiton-dd
added
the
Skip Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12673 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 479 479
Lines 26423 26423
=======================================
Hits 24214 24214
Misses 1749 1749
Partials 460 460 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mx-psi
approved these changes
Mar 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
@jade-guiton-dd could you fix the merge conflict? |
ArthurSens
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Yes, please revert! Sorry I didn't see the original PR on core. I've mentioned in contrib that we can't move forward with this upgrade yet. open-telemetry/opentelemetry-collector-contrib#38745 (comment)
I wonder why CI caught the problem on contrib, but not on core 🤔
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contrib tests are currently failing on main with the following build error:
I believe this is because of the update in #12656: there is a breaking change in
github.com/prometheus/common0.63.0 that is incompatible with the version ofgithub.com/prometheusused in some contrib modules. While the latter package has been updated on main, the updated version hasn't been released yet, so I this the only solution is to revert this PR until then.