Statically validate connector config during dry-run. #12712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #8721, the current
validate
command cannot capture improper connector usage errors during a dry run.One proposed solution (as mentioned in this comment) is to surface configuration errors by instantiating the service during the dry run. However, reviewers preferred statically verifying the errors over instantiating the service (see the PR #12488 comments).
The validation logic for connectors is located in the
service/internal/graph
package. In the discussion of PR #12681, it was concluded that instantiating the graph is the better approach (see this comment).Finally, this PR uses the
graph.Build()
method to surface configuration errors during the dry run.Link to tracking issue
Fixes #8721
Testing
Documentation