Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically validate connector config during dry-run. #12712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sudiptob2
Copy link
Contributor

@sudiptob2 sudiptob2 commented Mar 24, 2025

Description

As described in #8721, the current validate command cannot capture improper connector usage errors during a dry run.

One proposed solution (as mentioned in this comment) is to surface configuration errors by instantiating the service during the dry run. However, reviewers preferred statically verifying the errors over instantiating the service (see the PR #12488 comments).

The validation logic for connectors is located in the service/internal/graph package. In the discussion of PR #12681, it was concluded that instantiating the graph is the better approach (see this comment).

Finally, this PR uses the graph.Build() method to surface configuration errors during the dry run.

Link to tracking issue

Fixes #8721

Testing

Documentation

@sudiptob2 sudiptob2 force-pushed the feat/config-validation-graph-ins branch from ee5e5cd to 92d543e Compare March 24, 2025 18:42
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (622ce90) to head (92d543e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12712      +/-   ##
==========================================
+ Coverage   91.53%   91.55%   +0.01%     
==========================================
  Files         483      483              
  Lines       26453    26488      +35     
==========================================
+ Hits        24215    24250      +35     
  Misses       1772     1772              
  Partials      466      466              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sudiptob2 sudiptob2 marked this pull request as ready for review March 24, 2025 19:17
@sudiptob2 sudiptob2 requested a review from a team as a code owner March 24, 2025 19:17
@sudiptob2 sudiptob2 requested a review from jmacd March 24, 2025 19:17
@sudiptob2
Copy link
Contributor Author

cc: @djaglowski @mx-psi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate Connector Usage
1 participant