confighttp: Ensure that auth errors use provided error handler #12714
+72
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage from auth extensions is included in the response
The committers listed above are authorized under a signed CLA. |
|
I noticed there may be a conflict with an existing PR #12702 , but I wanted to make sure that this issue was brought up before the refactoring, let me know if there are any further changes I need to make. |
jmacd
approved these changes
Mar 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12714 +/- ##
=======================================
Coverage 91.53% 91.54%
=======================================
Files 483 483
Lines 26453 26456 +3
=======================================
+ Hits 24215 24218 +3
Misses 1772 1772
Partials 466 466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iblancasa
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OTLP/HTTP receiver does not encode authentication errors into a
Statusobject, and as such not expose a developer facing error message in theStatus.mesagefield. - https://opentelemetry.io/docs/specs/otlp/#failures-1Resolves this issue by handling authentication errors with the same error handler provided to the Server.
Link to tracking issue
Fixes #12666
Testing
Unit tests for handling errors with and without a server error handler