[exporter][batching] Replace timer with ticker #12720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
requested review from
bogdandrutu,
dmitryax and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12720 +/- ##
==========================================
- Coverage 91.50% 91.50% -0.01%
==========================================
Files 480 480
Lines 26464 26463 -1
==========================================
- Hits 24217 24216 -1
Misses 1778 1778
Partials 469 469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iblancasa
reviewed
Mar 25, 2025
| @@ -591,8 +591,8 @@ func TestQueueBatchTimerFlush(t *testing.T) { | |||
| assert.LessOrEqual(t, 1, sink.RequestsCount()) | |||
| assert.Equal(t, 8, sink.ItemsCount()) | |||
|
|
|||
| // Confirm that it is flushed after 100ms (using 60+50=110 here to be safe) | |||
There was a problem hiding this comment.
Would it make sense to replace this by assert.Eventually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves time keeping into individual
batchobject frombatcher. This is because when we support key-based batching, eachbatcherwill have multiplebatches.Link to tracking issue
#12473
Testing
Documentation