[chore] Added a workflow to lint YAML files using actionlint #12721
Conversation
…e renovate.json - Use specific version for docker actionlint image - Configured renovate.json to track docker image updates
- build-and-test-windows.yaml: (line 42 & 71) Used \ at EOL to explicitly tell the shell to continue on the next - generate-semantic-conventions-pr.yaml: disabled SC2034 warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12721 +/- ##
=======================================
Coverage 91.53% 91.54%
=======================================
Files 483 480 -3
Lines 26453 26456 +3
=======================================
+ Hits 24215 24218 +3
Misses 1772 1772
Partials 466 466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -105,5 +105,5 @@ jobs: | |||
| url=$(gh pr create --title "$message" \ | |||
| --body "$body" \ | |||
| --base main) | |||
|
|
|||
| # shellcheck disable=SC2034 | |||
There was a problem hiding this comment.
Can you add a comment explaining why this was disabled?
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Pre-pull Docker Image | ||
| run: docker pull rhysd/actionlint:${{ env.ACTIONLINT_VERSION }} |
There was a problem hiding this comment.
This is a Go tool so we can add it to the internal/tools/go.mod file and install it using make install-tools instead of this. That will allow us to get automatic updates without special renovate configuration
| -ignore 'SC2086' \ | ||
| -ignore 'SC2046' \ | ||
| -ignore 'SC2059' \ | ||
| -ignore 'SC2236' \ | ||
| -ignore 'SC1001' \ | ||
| -ignore 'SC2129' \ |
There was a problem hiding this comment.
Let's move all the configuration to a file https://github.com/rhysd/actionlint/blob/v1.7.7/docs/config.md#configuration-file and add a comment explaining why we are ignoring these
Description
This pull request builds on the work done in #11493
Link to tracking issue
#9676
Fixes
Testing
Documentation
No new documentation added, as this change is self-explanatory within the context of CI.