Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wait_for_result, remove disabled_queue #12742

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

bogdandrutu
Copy link
Member

In this PR, we merge the functionality from "disabled_queue" within the memory queue. For the moment this functionality is not available for the persistent queue.

In the next PR, will merge the internal.QueueConfig with queuebatch.Config.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners March 26, 2025 18:09
@bogdandrutu bogdandrutu force-pushed the rm-disabled branch 4 times, most recently from 14da981 to 60ba306 Compare March 26, 2025 18:24
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 90.78947% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.58%. Comparing base (eb00c82) to head (55bb93a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/queue_sender.go 73.17% 9 Missing and 2 partials ⚠️
.../exporterhelper/internal/queuebatch/queue_batch.go 86.36% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (90.78%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12742      +/-   ##
==========================================
+ Coverage   91.50%   91.58%   +0.07%     
==========================================
  Files         480      479       -1     
  Lines       26464    26484      +20     
==========================================
+ Hits        24217    24255      +38     
+ Misses       1778     1757      -21     
- Partials      469      472       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 26, 2025
@bogdandrutu bogdandrutu removed this pull request from the merge queue due to a manual request Mar 26, 2025
@bogdandrutu bogdandrutu enabled auto-merge March 26, 2025 19:29
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 26, 2025
Merged via the queue into open-telemetry:main with commit 540d6ed Mar 26, 2025
52 of 56 checks passed
@bogdandrutu bogdandrutu deleted the rm-disabled branch March 26, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants