Enable .NET analyzers and resolve warnings

[martincostello]

Changes

Enable .NET analyzers and address recommendations to:

• avoid redundant work and formatted strings for logging;
• fix incorrect use of ArgumentNullException;
• avoiding an instance method that does not access state by making it static.

Running dotnet build --configuration Release with these changes has no compiler errors.

Relates to #2413 (comment).

/cc @martinjt

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

• CHANGELOG.md updated to document new feature additions
• Appropriate documentation updates in the docs
• Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

[julianocosta89]

@martincostello is this one good to go?

[martincostello]

If people are happy with the direction, yes.

[Copilot]

Pull request overview

This PR enables .NET code analyzers in Release configuration and addresses analyzer warnings to improve code quality. The changes focus on optimizing logging performance, fixing incorrect exception usage, and applying best practices.

Key Changes:

• Added AnalysisMode>Minimum</AnalysisMode> to enable .NET analyzers in Release builds for cart and accounting services
• Converted string interpolation to structured logging with proper placeholders and added IsEnabled checks to avoid unnecessary work
• Changed ArgumentNullException to InvalidOperationException for environment variable validation (correct exception type for missing configuration)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/cart/Directory.Build.props	Enables minimum analysis mode for Release configuration
src/accounting/Directory.Build.props	Enables minimum analysis mode for Release configuration
src/cart/src/cartstore/ValkeyCartStore.cs	Converts logging to structured format with IsEnabled guards for performance optimization
src/accounting/Consumer.cs	Fixes exception type, converts to structured logging, and makes BuildConsumer method static

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[julianocosta89]

If people are happy with the direction, yes.

I'm okay with it!
It's 2 .NET Martin s against one not .NET Juliano 😅

Would you be able to take a look at Copilot review and check if it makes sense?
Honestly IDK where that came from 🤷🏽

[martincostello]

Would you be able to take a look at Copilot review and check if it makes sense

Done.

Honestly IDK where that came from

I imagine someone's enabled the "ask for Copilot reviews" ruleset.

[martincostello]

Well that last quick edit proved-out the CI failure 😅