[Instrumentation.AspNet] pass http.request.method to sampler

[roycald245]

Fixes #57287

Changes

Added http.request.method to tags given to sampler

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

[vishweshbankwar]

I think we need to set the normalized value as we do here

If the method is normalized to _OTHER then should we also include http.request.method_original, that part is not very clear in spec

[roycald245]

fixed 34e7fa3

[roycald245]

I think setting "HTTP" like the example you sent is the way to go. Keeping the convention.

[Kielek]

@roycald245, one test is failing.

[roycald245]

I had some distractions recently. Will fix as soon as I'm able

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (71655ce) to head (ccb159a).
Report is 542 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
+ Coverage   73.91%   77.32%   +3.40%     
==========================================
  Files         267       15     -252     
  Lines        9615      366    -9249     
==========================================
- Hits         7107      283    -6824     
+ Misses       2508       83    -2425     

Flag	Coverage Δ
unittests-Instrumentation.AspNet	77.32% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ation.AspNet.TelemetryHttpModule/ActivityHelper.cs	87.83% <100.00%> (+2.59%)	⬆️

... and 267 files with indirect coverage changes

[Kielek]

@roycald245, I have made some direct changes to

• handle http method attributes as in RequestDataHelper.SetHttpMethodTag
• fix cashing tags storage
• extend tests

Please double check if you are fine with this solution.

@cijothomas, could you please review?

[ysolomchenko]

LGTM

[roycald245]

Need codeowner approval

[CodeBlanch]

• We can probably remove this also being done in AspNet because sampler tags are automatically added to the span IIRC:

  opentelemetry-dotnet-contrib/src/OpenTelemetry.Instrumentation.AspNet/Implementation/HttpInListener.cs

  Line 77 in 32c4e94

  this.requestDataHelper.SetHttpMethodTag(activity, originalHttpMethod);

• Consider refactoring this into RequestDataHelper something like this...

RequestDataHelper.SetHttpMethodTag(tags, originalHttpMethod: context.Request.HttpMethod);

class RequestDataHelper
{
    public void SetHttpMethodTag(List<KeyValuePair<string, object?>> tags, string originalHttpMethod)
    {
        var normalizedHttpMethod = this.GetNormalizedHttpMethod(originalHttpMethod);
        tags.Add(new(SemanticConventions.AttributeHttpRequestMethod, normalizedHttpMethod));

        if (originalHttpMethod != normalizedHttpMethod)
        {
            tags.Add(new(SemanticConventions.AttributeHttpRequestMethodOriginal, originalHttpMethod));
        }
    }
}

Reason being it seems like all of this logic is already encapsulated inside RequestDataHelper.

[CodeBlanch]

Is it possible for context to be null here?

Suggested change

	string? path = context.Request?.Unvalidated?.Path;
	string? originalHttpMethod = context.Request?.HttpMethod;
	string? path = context.Request.Unvalidated?.Path;
	string originalHttpMethod = context.Request.HttpMethod;

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[Kielek]

@roycald245, do you have some time to address @CodeBlanch comments?