Skip to content

refactor(automation): remove SNAPSHOT tracking shared helpers (#1152) - #1352

Merged
jaydeluca merged 1 commit into
open-telemetry:mainfrom
SurbhiAgarwal1:feat/1152-cleanup-snapshot-shared-code
Nov 1, 2026
Merged

jaydeluca merged 1 commit into
open-telemetry:mainfrom
SurbhiAgarwal1:feat/1152-cleanup-snapshot-shared-code

Conversation

@SurbhiAgarwal1

Copy link
Copy Markdown
Contributor

What changed

Removed obsolete SNAPSHOT helper methods and tests across \watcher-common\ and individual watchers now that all registries track official releases only, completing the cleanup planned in #1152.

  • Removed \determine_next_snapshot_version\ from \VersionDetector\
  • Removed \list_snapshot_versions\ and \cleanup_snapshots\ from \BaseInventoryManager\ and \collector_watcher.InventoryManager\
  • Removed obsolete snapshot unit tests across \collector, \configuration, \dotnet, and \java\ test suites
  • Updated \AGENTS.md\ documentation

Why

Fixes #1152
With Java (#1340), .NET (#1343), Configuration (#1347), and Collector (#1349) registries all migrated to tracking official releases only, these shared snapshot helpers and cleanup functions are no longer used anywhere in the codebase.

Checklist

  • Tests updated/cleaned up
  • DCO sign-off included

Copilot AI balanced review requested due to automatic review settings October 31, 2026 18:04
@SurbhiAgarwal1
SurbhiAgarwal1 requested review from a team as code owners October 31, 2026 18:04
@netlify

netlify Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for otel-ecosystem-explorer canceled.

Name Link
🔨 Latest commit ed49851
🔍 Latest deploy log https://app.netlify.com/projects/otel-ecosystem-explorer/deploys/6ae6e0e050950f313d6adcba

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-11-01 15:15 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@SurbhiAgarwal1
SurbhiAgarwal1 force-pushed the feat/1152-cleanup-snapshot-shared-code branch from d0e51e6 to f9f552a Compare November 1, 2026 06:42
@opentelemetry-pr-dashboard
opentelemetry-pr-dashboard Bot requested a balanced review from Copilot November 1, 2026 06:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

…elemetry#1152)

Remove obsolete SNAPSHOT helper methods and tests across watcher-common and watchers now that all registries track official releases only. Part of open-telemetry#1152.

- Remove determine_next_snapshot_version from VersionDetector
- Remove list_snapshot_versions and cleanup_snapshots from BaseInventoryManager and collector-watcher InventoryManager
- Remove obsolete snapshot tests in collector, configuration, dotnet, and java test suites
- Update AGENTS.md documentation

Signed-off-by: Surbhi Agarwal <SurbhiAgarwal1@users.noreply.github.com>
@SurbhiAgarwal1
SurbhiAgarwal1 force-pushed the feat/1152-cleanup-snapshot-shared-code branch from f9f552a to ed49851 Compare November 1, 2026 06:49
@opentelemetry-pr-dashboard
opentelemetry-pr-dashboard Bot requested a balanced review from Copilot November 1, 2026 06:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@jaydeluca jaydeluca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jaydeluca
jaydeluca added this pull request to the merge queue Nov 1, 2026
Merged via the queue into open-telemetry:main with commit 60bbb18 Nov 1, 2026
32 checks passed
@otelbot

otelbot Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @SurbhiAgarwal1! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide if tracking the SNAPSHOT versions in registry is useful

3 participants