-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for excluded modules #702
Update dependencies for excluded modules #702
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 52.41% 52.32% -0.10%
==========================================
Files 57 58 +1
Lines 3478 3490 +12
==========================================
+ Hits 1823 1826 +3
- Misses 1481 1487 +6
- Partials 174 177 +3 ☔ View full report in Codecov by Sentry. |
@open-telemetry/collector-approvers, can you take a look and make sure it also won't cause any problems for the Collector releases? |
Part of open-telemetry/opentelemetry-go-contrib#6440
Currently, the
prerelease
command won't update the version of dependencies for excluded modules. This brings an issue whereprerelease
cannot update dependencies for those example packages, which usually won't be released (thus excluded).This PR fixes this issue by scanning all go modules under the root path regardless of whether they are excluded or not.
Blocked by #703