Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for excluded modules #702

Merged

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Feb 27, 2025

Part of open-telemetry/opentelemetry-go-contrib#6440

Currently, the prerelease command won't update the version of dependencies for excluded modules. This brings an issue where prerelease cannot update dependencies for those example packages, which usually won't be released (thus excluded).

This PR fixes this issue by scanning all go modules under the root path regardless of whether they are excluded or not.

Blocked by #703

@XSAM XSAM requested review from a team as code owners February 27, 2025 01:30
@XSAM XSAM requested a review from bogdandrutu February 27, 2025 01:30
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 52.32%. Comparing base (af209eb) to head (50006d4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
multimod/internal/common/all_mod.go 61.53% 7 Missing and 3 partials ⚠️
multimod/internal/common/module_set_release.go 40.00% 2 Missing and 1 partial ⚠️
multimod/internal/common/versions.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   52.41%   52.32%   -0.10%     
==========================================
  Files          57       58       +1     
  Lines        3478     3490      +12     
==========================================
+ Hits         1823     1826       +3     
- Misses       1481     1487       +6     
- Partials      174      177       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pellared
Copy link
Member

@open-telemetry/collector-approvers, can you take a look and make sure it also won't cause any problems for the Collector releases?

@pellared pellared merged commit 5886c8b into open-telemetry:main Mar 3, 2025
12 checks passed
@pellared pellared mentioned this pull request Mar 3, 2025
@XSAM XSAM deleted the fix-dependencies-update-for-excluded branch March 4, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants