Skip to content

Update renovate config #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,28 @@
extends: [
'config:recommended',
'docker:pinDigests',
'helpers:pinGitHubActionDigests',
'helpers:pinGitHubActionDigestsToSemver',
],
ignorePresets: [
':ignoreModulesAndTests', // needed to keep maven-extension test pom files up-to-date
],
prHourlyLimit: 5,
prHourlyLimit: 5, // we have a large number of parallel runners
labels: [
'dependencies'
],
packageRules: [
{
// this is to reduce the number of renovate PRs
matchManagers: [
'github-actions',
'dockerfile',
],
extends: [
'schedule:weekly',
],
groupName: 'weekly update',
// reduces the number of Renovate PRs
// (patch updates are typically non-breaking)
"groupName": "all patch versions",
"matchUpdateTypes": ["patch"],
"schedule": ["before 8am every weekday"]
},
{
// avoids these Renovate PRs from trickling in throughout the week
// (consolidating the review process)
"matchUpdateTypes": ["minor", "major"],
"schedule": ["before 8am on Monday"]
Comment on lines +24 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, I kinda like having them trickle in because I assume that it helps spread the work across approver availability more evenly...but I dunno. This still separates packges into separate PRs tho right, not one big PR monday monring?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that makes sense, but this also rings true

Receiving PRs at any hour can increase the feeling of being "overwhelmed" by updates and possibly interrupt your flow during working hours, so many Renovate users also consider reducing Renovate's schedule to be outside their normal working hours, for example weeknights and weekends.

https://docs.renovatebot.com/noise-reduction/

I kind of like the idea of dealing with renovate PRs in the morning and not having them trickle in, but not sure how to balance that across multiple maintainers and multiple definitions of morning

},
{
matchPackageNames: [
Expand Down
Loading