Skip to content

add option to record transferred artifacts #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smurf667
Copy link

@smurf667 smurf667 commented May 4, 2025

Description:

This adds a TransferListener to the maven-extension so that artifact transfers can be recorded optionally.

Existing Issue(s):

See #1874

Testing:

DRAFT: No additional testing has been added yet.

Documentation:

DRAFT: No additional documentation has been added yet.

Outstanding items:

  • See above: Additional tests and documentation still need to be done.
  • Filtering of transfers below a certain threshold (size, duration) is not implemented yet; I tried to add a custom SpanExporter in OpenTelemetrySdkService - is see it getting called and filtering, but when I used the Jaeger UI setup (see blog) all spans were unexpectedly shown. The issue appears that the span must be created first (because the transfer events define start and end), but those not matching the thresholds should be ignored, and I don't know how to do that other than with the exporter.
  • I am not deeply familiar with the OpenTelemetry API nor the Maven APIs, so some things may have to be rectified.
  • There are some TODOs that should be addressed.

Copy link

linux-foundation-easycla bot commented May 4, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants