Disk buffering reading refactor #1917
Merged
+227
−298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔧 The result from spotlessApply was committed to the PR branch. |
zeitlinger
reviewed
May 28, 2025
# Conflicts: # disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/FromDiskExporterImplTest.java # disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/SpanFromDiskExporterTest.java # disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/storage/TestData.java
|
@zeitlinger - After your changes were merged, I got 2 minor conflicts with some test files that are now solved. So the changes in this PR should be ready to go now, please have a look. |
zeitlinger
approved these changes
Jun 2, 2025
trask
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Should fix #1907
It also simplifies the reading process by removing the need to create a temporary file. Now that disk-buffering has been used for a while, there are some ideas of what's commonly used or needed, so I'm planning to keep on improving its API in further PRs to hopefully reach a stable status soon. In the meantime, these changes should be enough to fix the mentioned issue.