Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking OSSF Scorecard improvements #13157

Closed
trask opened this issue Feb 1, 2025 · 9 comments
Closed

Tracking OSSF Scorecard improvements #13157

trask opened this issue Feb 1, 2025 · 9 comments

Comments

@trask
Copy link
Member

trask commented Feb 1, 2025

https://securityscorecards.dev/viewer/?uri=github.com/open-telemetry/opentelemetry-java-instrumentation

@trask
Copy link
Member Author

trask commented Feb 1, 2025

I don't understand why our "Token-Permissions" score is still 0/10. This is my latest attempt: #13156

UPDATE: that fixed the Token-Permissions score, now 10/10

@trask
Copy link
Member Author

trask commented Feb 2, 2025

I answered questions for OpenSSF Best Practices program, which should bump our "CII-Best-Practices" score from 0/10 to 5/10.

@trask
Copy link
Member Author

trask commented Feb 2, 2025

Next: convert from classic "branch protections" to "repository rules" as part of https://github.com/ossf/scorecard-action#authentication-with-fine-grained-pat-optional

UPDATE: I've enabled a ruleset on main to potentially replace the branch protection on main. I've set the ruleset enforcement to "Evaluate" which I think means it shouldn't prevent anything from happening, but we might(?) see it referenced in PRs, not sure...

@trask
Copy link
Member Author

trask commented Feb 3, 2025

@trask
Copy link
Member Author

trask commented Feb 4, 2025

#13179 solved the gradle wrapper issue

@trask
Copy link
Member Author

trask commented Feb 4, 2025

#13199 finally made OSSF SAST happy (need 30 PR commits that have been checked prior to merging in order to make it fully happy)

@trask
Copy link
Member Author

trask commented Feb 5, 2025

#13210 didn't fix the Branch-Protection check

@trask
Copy link
Member Author

trask commented Feb 5, 2025

The Branch-Protection check fails if there are any branch protections that have any matching branches.

Unfortunately there doesn't seem to be a way to achieve this using rule sets:

## Branch protections
### `main`, `release/*`, `v0.*`, `v1.*`, `cloudfoundry`
- Restrict who can push to matching branches: CHECKED
- Restrict pushes that create matching branches: CHECKED

@trask
Copy link
Member Author

trask commented Feb 19, 2025

Closing, can always follow-up on individual items later

@trask trask closed this as completed Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@trask and others