Move from branch protections to rule sets #13165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
rulesets
branch
2 times, most recently
from
754371c to
7c89a37
Compare
breedx-splk
reviewed
Feb 3, 2025
| - `main` | ||
| - `release/*` | ||
| - `v0.*` | ||
| - `v1.*` |
There was a problem hiding this comment.
Do we also want v2.* here for patch branches and v3.* here for future-proofing?
There was a problem hiding this comment.
we use release/v* now, v* was an old convention we used up until 1.12.0
laurit
approved these changes
Feb 3, 2025
breedx-splk
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #13157 (comment)
also, rulesets fixes the most annoying thing about branch protection rules which is that ordering matters and there's no UI for moving them around, so creating new ones is painful