Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AgentForTestingTest.exportAndRetrieveMetrics() #13414

Merged
merged 18 commits into from
Mar 4, 2025
Merged

Add AgentForTestingTest.exportAndRetrieveMetrics() #13414

merged 18 commits into from
Mar 4, 2025

Conversation

chlos
Copy link
Contributor

@chlos chlos commented Feb 27, 2025 •
edited
Loading

Currently only spans exporting and retrieving is tested in AgentForTestingTest.exportAndRetrieve(). Let's:

  • Have a separate spans test (basically rename exportAndRetrieve() to exportAndRetrieveSpans())
  • Add a new metrics test: exportAndRetrieveMetrics()

This test is supposed to cover javaagent.testing issues like this: #13401

@chlos chlos requested a review from a team as a code owner February 27, 2025 17:59
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 27, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@chlos chlos mentioned this pull request Feb 27, 2025
Open
@laurit laurit mentioned this pull request Feb 28, 2025
Merged
@laurit
Copy link
Contributor

laurit commented Feb 28, 2025

@chlos #13423 should get this test passing

renovate bot and others added 14 commits March 3, 2025 12:18
@renovate @chlos
fix(deps): update quarkus packages to v3.15.3.1 (patch) (open-telemet…
674d512 
…ry#13413)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jeanbisutti @steverao
@laurit @trask @chlos
Redact query string values for http client spans (open-telemetry#13114)
6951c2b 
Co-authored-by: Steve Rao <[email protected]>
Co-authored-by: Lauri Tulmin <[email protected]>
Co-authored-by: Lauri Tulmin <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
@trask @chlos
Better benchmark-overhead test logging (open-telemetry#13415)
2064072
@renovate @chlos
fix(deps): update dependency com.uber.nullaway:nullaway to v0.12.4 (o…
becacd8 
…pen-telemetry#13416)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @chlos
fix(deps): update dependency org.codehaus.groovy:groovy-bom to v3.0.24 (
24c80ec 
open-telemetry#13417)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @chlos
fix(deps): update groovy monorepo to v4.0.26 (patch) (open-telemetry#…
8c1e4f2 
…13421)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@trask @chlos
Fix benchmark-overhead compilation (open-telemetry#13418)
ffd0b1a
@laurit @chlos
Add all otel api bridging instrumentations to testing agent (open-tel…
10034d8 
…emetry#13423)
@otelbot @laurit @chlos
Merge change log updates from release/v2.13.x (open-telemetry#13426)
b8a5b50 
Co-authored-by: otelbot <[email protected]>
Co-authored-by: Lauri Tulmin <[email protected]>
@renovate @chlos
fix(deps): update dependency com.fasterxml.jackson.core:jackson-datab…
9571a98 
…ind to v2.18.3 (open-telemetry#13428)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @laurit @chlos
fix(deps): update dependency com.fasterxml.jackson:jackson-bom to v2.…
98ef9a0 
…18.3 (open-telemetry#13429)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lauri Tulmin <[email protected]>
@laurit @chlos
Fix adding logback mdc appender in spring starter (open-telemetry#13391)
d9356df
@renovate @chlos
chore(deps): update weekly update (open-telemetry#13437)
373bf80 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@laurit @chlos
Group renovate updates for jackson (open-telemetry#13433)
c04d3ef
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Mar 3, 2025
@trask trask merged commit f2d0e15 into open-telemetry:main Mar 4, 2025
61 checks passed
@chlos chlos mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

@steverao steverao steverao approved these changes

Assignees
No one assigned
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chlos @laurit @jaydeluca @steverao @trask @jeanbisutti