Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all otel api bridging instrumentations to testing agent #13423

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 28, 2025

Related to #13414

baseJavaagentLibs(project(":instrumentation:opentelemetry-api:opentelemetry-api-1.38:javaagent"))
baseJavaagentLibs(project(":instrumentation:opentelemetry-api:opentelemetry-api-1.40:javaagent"))
baseJavaagentLibs(project(":instrumentation:opentelemetry-api:opentelemetry-api-1.42:javaagent"))
baseJavaagentLibs(project(":instrumentation:opentelemetry-api:opentelemetry-api-1.47:javaagent"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you get such a specific list of javaagent versions?

Copy link
Contributor Author

@laurit laurit Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not agent versions but instrumentations for specific opentelemetry-api versions that introduce new features. In our tests we mostly test instrumentations that use the shaded opentelemetry api provided by the agent. Your test brings its own opentelemetry api so it requires the instrumentations that bridge the api you have to the agent api.

@laurit laurit merged commit 1323395 into open-telemetry:main Feb 28, 2025
61 checks passed
@laurit laurit deleted the testing-agent-otel-api branch February 28, 2025 17:10
chlos pushed a commit to chlos/opentelemetry-java-instrumentation that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants