add in starter: annotations #10613
add in starter: annotations #10613
Conversation
| implementation(project(":instrumentation:resources:library")) | ||
| implementation("io.opentelemetry:opentelemetry-extension-trace-propagators") | ||
| implementation("io.opentelemetry.contrib:opentelemetry-aws-xray-propagator") |
There was a problem hiding this comment.
It is an extension located in the Java contrib repo (https://github.com/open-telemetry/opentelemetry-java-contrib). So, it would not make sense to enable it from a project located in the Java instrumentation Github repo.
There was a problem hiding this comment.
javaagent is also including it - and the docs mention it as one of the values.
There was a problem hiding this comment.
Could you please elaborate with links
There was a problem hiding this comment.
There was a problem hiding this comment.
Agent includes it because we have instrumentations that use this propagator. On the one hand including it is fine because the propagator is small and doesn't have dependencies. On the other hand getting rid of it later on might be difficult once the starter is stable. I'd personally not include it and I would also not include opentelemetry-extension-trace-propagators. The code in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/propagators/CompositeTextMapPropagatorFactory.java already treats these as optional dependencies, I see no compelling reason for changing this.
You may wish to raise this on the SIG meeting if you believe that these should be included.
There was a problem hiding this comment.
No, it's not a priority for me - we'll just document that.
There was a problem hiding this comment.
@laurit I removed the resource propagators
zeitlinger
changed the title
add in starter: annotations (but remove the old annotation lib)