Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest resource detector #10621

Merged
merged 14 commits into from
Mar 13, 2024
Merged

Manifest resource detector #10621

merged 14 commits into from
Mar 13, 2024

Conversation

zeitlinger
Copy link
Member

Fixes #10615

@zeitlinger zeitlinger self-assigned this Feb 21, 2024
@zeitlinger zeitlinger requested a review from a team February 21, 2024 12:49
@zeitlinger zeitlinger force-pushed the manifest-resource-detector branch from e4b6ca0 to b372f09 Compare February 21, 2024 14:45
@zeitlinger zeitlinger mentioned this pull request Feb 21, 2024
Merged
@zeitlinger zeitlinger force-pushed the manifest-resource-detector branch 2 times, most recently from 73ba3c3 to b40416b Compare February 22, 2024 11:39
@zeitlinger zeitlinger mentioned this pull request Feb 22, 2024
Closed
@jeanbisutti jeanbisutti mentioned this pull request Feb 22, 2024
Closed
@zeitlinger zeitlinger mentioned this pull request Feb 22, 2024
Closed
@zeitlinger zeitlinger force-pushed the manifest-resource-detector branch from da5bbdb to 10f0e36 Compare February 23, 2024 15:13
@jeanbisutti jeanbisutti added the test native This label can be applied to PRs to trigger them to run native tests label Mar 1, 2024
@jeanbisutti jeanbisutti closed this Mar 1, 2024
@jeanbisutti jeanbisutti reopened this Mar 1, 2024
@jeanbisutti jeanbisutti closed this Mar 1, 2024
@jeanbisutti jeanbisutti reopened this Mar 1, 2024
@zeitlinger zeitlinger force-pushed the manifest-resource-detector branch from 10f0e36 to 8f84013 Compare March 1, 2024 11:39
@zeitlinger zeitlinger added this to the v2.2.0 milestone Mar 11, 2024
@zeitlinger zeitlinger force-pushed the manifest-resource-detector branch from 7368dc9 to 2672296 Compare March 11, 2024 15:38
@zeitlinger zeitlinger force-pushed the manifest-resource-detector branch from 2672296 to acf1dcf Compare March 12, 2024 12:20
@github-actions github-actions bot requested a review from theletterf March 12, 2024 12:25
@zeitlinger zeitlinger force-pushed the manifest-resource-detector branch from acf1dcf to 4eb9368 Compare March 12, 2024 15:05
@zeitlinger zeitlinger force-pushed the manifest-resource-detector branch from 4eb9368 to 9cc81e1 Compare March 13, 2024 14:54
@zeitlinger @trask
Update instrumentation/resources/library/src/main/java/io/opentelemet…
8cabb44 
…ry/instrumentation/resources/ManifestResourceProvider.java

Co-authored-by: Trask Stalnaker <[email protected]>
@trask trask merged commit 5df8a5a into open-telemetry:main Mar 13, 2024
49 checks passed
@zeitlinger zeitlinger deleted the manifest-resource-detector branch March 14, 2024 06:46
@zeitlinger
Copy link
Member Author

@laurit thanks for the review - please have a look now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@laurit laurit laurit left review comments

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@theletterf theletterf Awaiting requested review from theletterf

Assignees

@zeitlinger zeitlinger

Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

detect service.name and service.version based on Implementation-Title and Implementation-Version
4 participants
@zeitlinger @trask @laurit @jeanbisutti