-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polished contributing document #10693
Conversation
Keep first letter capitalized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this is one sentence that has 2 embedded code snippets. In my opinion capitalizing it this way is not needed.
I think it's a little special here, If they are all in one sentence, without marks will make the sentence look a bit strange. I think the current way they are arranged, it is necessary to first letter capitalized, which looks more coordinate a bit. Sure, I can turn it off if you still don't think it's necessary? |
@theletterf can you give us your expert opinion? Thanks! |
So, when you're interspersing code snippets with sentences, it doesn't need a capital letter because it's all part of the same sentence. I think the snippets could use some restructuring though — here's my suggestion, which eliminates the issue and restores a semblance of capitalization. ;)
|
Thanks @theletterf! Except using |
@theletterf 's suggestion looks good. |
Polished contributing document