-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce flakyness of Resource tests #12252
Merged
trask
merged 6 commits into
open-telemetry:main
from
jaydeluca:declarative-config-flakyness
Sep 16, 2024
Merged
Reduce flakyness of Resource tests #12252
trask
merged 6 commits into
open-telemetry:main
from
jaydeluca:declarative-config-flakyness
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is not a good way to fix this issue. The reason this test is flaky (it actually reliably fails on the first execution and passes on retry) is that it depends on the order tests are run. If Line 40 in 2d5775a
host.arch you'll next run into the same issue with os.description (at least that is what happened when I disabled HostResourceTest.SecurityManagerEnabled ). Perhaps we should move all the security manager tests to a separate suite so they couldn't interfere with the main suite.I can reliably reproduce this with running ./gradlew :instrumentation:resources:library:clean and ./gradlew :instrumentation:resources:library:test --no-build-cache -PtestJavaVersion=8
|
jaydeluca
commented
Sep 15, 2024
...ources/library/src/main/java/io/opentelemetry/instrumentation/resources/ProcessResource.java
Outdated
Show resolved
Hide resolved
…mentation into declarative-config-flakyness
laurit
reviewed
Sep 16, 2024
...rityManager/java/io/opentelemetry/instrumentation/resources/SecurityManagerResourceTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 16, 2024
...rityManager/java/io/opentelemetry/instrumentation/resources/SecurityManagerResourceTest.java
Outdated
Show resolved
Hide resolved
…stResource attribute constants private
laurit
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is 43% flaky
Looking at the failures, it is that the
host.arch
attribute is not reliableMoving the Security Manager tests to their own test suite to avoid them altering the environment, causing issues with other tests