Add FOSSA license scanning #13257
Merged
Add FOSSA license scanning #13257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
trask
commented
Feb 10, 2025
| @@ -8,7 +8,7 @@ group = "io.opentelemetry.instrumentation" | |||
| val springBootVersion = "2.6.15" | |||
|
|
|||
| dependencies { | |||
| api("org.springframework.boot:spring-boot-starter:$springBootVersion") | |||
| compileOnly("org.springframework.boot:spring-boot-starter:$springBootVersion") | |||
There was a problem hiding this comment.
@jeanbisutti @zeitlinger is this ok? I noticed it was compileOnly in the main starter (the reason it's related to this PR is that we're only scanning runtimeClasspath dependencies)
There was a problem hiding this comment.
compileOnly would make more sense for me
trask
commented
Feb 10, 2025
Comment on lines
-7
to
-9
| val dependencyVersions = hashMapOf<String, String>() | ||
| rootProject.extra["versions"] = dependencyVersions | ||
|
|
There was a problem hiding this comment.
unrelated to this PR, but we weren't using this
trask
force-pushed
the
fossa
branch
2 times, most recently
from
e5ba5f5 to
93909ef
Compare
laurit
reviewed
Feb 10, 2025
build.gradle.kts
Outdated
Comment on lines
142
to
156
| // disable all tasks to stop build | ||
| subprojects { | ||
| tasks.configureEach { | ||
| enabled = false | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // disable all tasks to stop build | ||
| project.tasks.configureEach { | ||
| if (this.name != "generateFossaConfiguration") { | ||
| enabled = false | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not sure you need this. listTestsInPartition uses this because it is run with ./gradlew check -x spotlessCheck listTestsInPartition We want to get names of all tests tasks that check would trigger but we don't want to actually run them.
laurit
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.