Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): migrate renovate config #13287

Merged
merged 2 commits into from
Feb 14, 2025
Merged

chore(config): migrate renovate config #13287

merged 2 commits into from
Feb 14, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 13, 2025

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.

You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.

PLEASE NOTE: JSON5 config file migrated! All comments & trailing commas were removed.

🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.

❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.


This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner February 13, 2025 00:17
@renovate renovate bot mentioned this pull request Feb 13, 2025
6 tasks
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the point of using json5 if our comments are going to be deleted? 😅

@trask
Copy link
Member

trask commented Feb 13, 2025

I guess at least they told us

PLEASE NOTE: JSON5 config file migrated! All comments & trailing commas were removed.

@trask trask force-pushed the renovate/migrate-config branch from ed03da2 to 85a4378 Compare February 13, 2025 00:31
"groupName": "quarkus packages"
groupName: 'quarkus packages',
matchPackageNames: [
'io.quarkus{/,}**',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we could simplify this to io.quarkus**, but I'd suggest we merge as-is and I might try this in a separate PR so that if it doesn't work we have a simple revert

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually restored the comments

@trask trask merged commit f2e51a0 into main Feb 14, 2025
62 checks passed
@trask trask deleted the renovate/migrate-config branch February 14, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant