Add release option to finish the release #13317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Feb 16, 2025
jaydeluca
reviewed
Feb 16, 2025
Co-authored-by: Jay DeLuca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the cause of the release failure here: #13316
Proposing to merge this directly into
release/v2.13.x, it should allow me to finish the release (and I can upload the attachments manually afterwards, including the SBOM which got attached to the failed release workflow already).At the same time, this should support releasing a v2.13.1 if we need to (i.e. I didn't completely hack up the workflow).
I don't think this is worth merging to
mainsince it's pretty specific to when it fails at this specific point in the workflow.