Fix release branch builds #13318
Merged
Fix release branch builds #13318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
fix-release-branch-builds
branch
from
4940e41 to
2ee7515
Compare
jaydeluca
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core repo already has this check
https://github.com/open-telemetry/opentelemetry-java/blob/3e1d9536f80603ce00a421b8e1cbc4cd82126738/.github/workflows/build.yml#L85-L88
we don't need the windows check here since we only run this on linux already
and I'm not sure why the opentelemetrybot check would be needed so left that out