Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for basic metadata.yaml file #13480

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Conversation

jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Mar 9, 2025

Related to #13468

@jaydeluca jaydeluca requested a review from a team as a code owner March 9, 2025 13:51
@jaydeluca jaydeluca mentioned this pull request Mar 8, 2025
17 tasks
Comment on lines -284 to -314
### Spock

The `testing-common` module contains some utilities that facilitate writing Spock instrumentation
tests, such as the `InstrumentationSpecification` base class and the `LibraryTestTrait`
and `AgentTestTrait` traits.

Consider the following abstract test class extending `InstrumentationSpecification`:

```groovy
abstract class AbstractYarpcTest extends InstrumentationSpecification {

abstract Yarpc configure(Yarpc yarpc);

def "test something"() {
// ...
}
}
```

The `InstrumentationSpecification` class contains abstract methods that are implemented by one of
our test traits in the actual test class. For example:

```groovy
class LibraryYarpcTest extends AbstractYarpcTest implements LibraryTestTrait {

@Override
Yarpc configure(Yarpc yarpc) {
// register interceptor/listener etc
}
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@trask trask merged commit 01cce80 into open-telemetry:main Mar 10, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants