Skip to content

Ensure dubbo agent tests are testing the agent #9617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

Ensure dubbo agent tests are testing the agent #9617

merged 1 commit into from
Oct 9, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 6, 2023

#9565 (comment) raised doubt whether dubbo tests really test the agent as they unexpectedly passed in indy mode

@laurit laurit requested a review from a team October 6, 2023 14:53
mateuszrzeszutek
mateuszrzeszutek approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@mateuszrzeszutek mateuszrzeszutek merged commit 4f538a8 into open-telemetry:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurit @mateuszrzeszutek