Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CodeQL on PRs #7070

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Run CodeQL on PRs #7070

merged 7 commits into from
Feb 7, 2025

Conversation

trask
Copy link
Member

@trask trask commented Feb 5, 2025

This is why OSSF Scorecard for SAST is only 7/10.

Related to #7068

@trask trask requested a review from a team as a code owner February 5, 2025 22:02
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (9f0a291) to head (48cb63b).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7070   +/-   ##
=========================================
  Coverage     89.84%   89.84%           
  Complexity     6610     6610           
=========================================
  Files           740      740           
  Lines         19981    19981           
  Branches       1966     1966           
=========================================
  Hits          17951    17951           
  Misses         1440     1440           
  Partials        590      590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

- main
- release/*
- v0.*
- v1.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have branches matching the v* pattern.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-telemetry/opentelemetry-java/branches/all?page=3

but I think you're right though that they shouldn't be needed here, let me try removing in instrumentation repo first to make sure OSSF doesn't get mad

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, these aren't needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the old release strategy. Yes, we should never push to these branches.

jobs:
analyze:
permissions:
contents: read
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant?

Suggested change
contents: read

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding is

  • technically the non-presence here removes a workflow-level permission (as opposed to being additive)
  • but that since our repos are public, you can never take away contents: read

so I think I can remove them, let me try this in instrumentation repo first also...

Copy link
Member Author

@trask trask Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this didn't work, see explanation in open-telemetry/opentelemetry-java-instrumentation#13247

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying.

@trask trask mentioned this pull request Feb 6, 2025
@jack-berg jack-berg merged commit 41c51a0 into open-telemetry:main Feb 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants