-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CodeQL on PRs #7070
Run CodeQL on PRs #7070
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7070 +/- ##
=========================================
Coverage 89.84% 89.84%
Complexity 6610 6610
=========================================
Files 740 740
Lines 19981 19981
Branches 1966 1966
=========================================
Hits 17951 17951
Misses 1440 1440
Partials 590 590 ☔ View full report in Codecov by Sentry. |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
.github/workflows/codeql.yml
Outdated
- main | ||
- release/* | ||
- v0.* | ||
- v1.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have branches matching the v*
pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/open-telemetry/opentelemetry-java/branches/all?page=3
but I think you're right though that they shouldn't be needed here, let me try removing in instrumentation repo first to make sure OSSF doesn't get mad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, these aren't needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah the old release strategy. Yes, we should never push to these branches.
jobs: | ||
analyze: | ||
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant?
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my understanding is
- technically the non-presence here removes a workflow-level permission (as opposed to being additive)
- but that since our repos are public, you can never take away
contents: read
so I think I can remove them, let me try this in instrumentation repo first also...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this didn't work, see explanation in open-telemetry/opentelemetry-java-instrumentation#13247
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trying.
This is why OSSF Scorecard for SAST is only 7/10.
Related to #7068