-
Notifications
You must be signed in to change notification settings - Fork 975
Add a ConfigProvider callback for runtime instrumentation option changes #8076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jackshirazi
wants to merge
16
commits into
open-telemetry:main
Choose a base branch
from
jackshirazi:config-provider-callback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0f34885
Adding a callback to ConfigProvider for runtime instrumentation optio…
jackshirazi 0d8e905
correct listener interface
jackshirazi ff2fed8
spotless
jackshirazi afea89d
feedback changes
jackshirazi 6c19201
tentative mutation of declarative config
jackshirazi 00ede1a
spotless
jackshirazi 4fa3872
fix failure
jackshirazi e985b03
test coverage
jackshirazi fb61cb9
spotless
jackshirazi 069ba38
warning fix
jackshirazi a4e42bf
test coverage
jackshirazi f90362a
test coverage
jackshirazi 0b26dfb
adapted from feedback
jackshirazi f45b2bb
spotless
jackshirazi 745d874
Merge remote-tracking branch 'origin/main' into config-provider-callback
jackshirazi 8f15038
Applied jack-berg changes
jackshirazi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
api/incubator/src/main/java/io/opentelemetry/api/incubator/config/ConfigChangeListener.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.api.incubator.config; | ||
|
|
||
| /** Listener notified when declarative configuration changes. */ | ||
| @FunctionalInterface | ||
| public interface ConfigChangeListener { | ||
|
|
||
| /** | ||
| * Called when the watched path changes. | ||
| * | ||
| * <p>{@code path} is the changed declarative configuration path, for example {@code | ||
| * .instrumentation/development.general.http} or {@code | ||
| * .instrumentation/development.java.methods}. | ||
| * | ||
| * <p>{@code newConfig} is never null. If the watched node is unset or cleared, {@code newConfig} | ||
| * is {@link DeclarativeConfigProperties#empty()}. | ||
| * | ||
| * @param path the declarative configuration path that changed | ||
| * @param newConfig the updated configuration for the changed path | ||
| */ | ||
| void onChange(String path, DeclarativeConfigProperties newConfig); | ||
| } |
18 changes: 18 additions & 0 deletions
18
...cubator/src/main/java/io/opentelemetry/api/incubator/config/ConfigChangeRegistration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.api.incubator.config; | ||
|
|
||
| /** Registration handle returned by {@link ConfigProvider#addConfigChangeListener}. */ | ||
| @FunctionalInterface | ||
| public interface ConfigChangeRegistration { | ||
|
|
||
| /** | ||
| * Unregister the listener associated with this registration. | ||
| * | ||
| * <p>Subsequent calls have no effect. | ||
| */ | ||
| void close(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.